Update setup-instructions-dockerless.md #10
Conversation
**If you have already cloned the ot-node repository:** ``` /root/ot-node/installer/installer.sh I think you actually have to be in /root/ot-node for the npm part of the script to work. Not sure about the latest versions of the script though.
There was a problem hiding this comment.
Some changes you made will have conflicts with my PR sent 24 days ago as we are both modifying the same instructions. I figured the instructions for installing the database should be at the front testnet page rather than dockerless setup page since the steps are similar for all 3 ways to install the node to come.
Second point:
wget https://tracdeepdive.info/wp-content/uploads/2022/02/graphdb-free-9.10.1-dist.zip is retired as the bandwidth has unfortunately been reached on our website (I am the main editor and the one who uploaded the graphdb there for ease of use). The team also said they did not want to have these instructions on their official docs as this is not the official way to get the graphdb. For the new unofficial way to get it using the terminal only, run the following:
apt install git python3-pip && pip install gdown && gdown https://drive.google.com/u/0/uc?id=1ZaStCOrP-_PLLdn-5kVJQPutPTbAgflY
Other than that, feel free to review my version as well and maybe apply your other corrections on that one !
|
Hum, I read the instructions as a whole and made modifications that sounded better to me. It's not a matter or right or wrong, it's just trying to improve clarity and detail. I submitted the changes as a suggestion for improvement, I don't expect them to necessarily be accepted as is; and I'm totally cool with them being rejected. I think the docs right now need a little bit of a cleanup, there is at least 1 redundant page imo. Also the flow of information could be reviewed, to make sure the transitions between topics/sections are clear to those who are not familiar with the current events, installation steps, etc. I could take a closer look and suggest changes, if the team sees any value in this. About your second point: ok. About the 'review to your version' / 'that one' - I'm not sure exactly which version you are referring too?... I'm happy to offer suggestions if you point me to the files. Cheers! |
|
I agree the doc needs some cleanup, and the team is behind on PRs and now we have your modifications and mine to review, which would create a conflict if one or the other is merged. |
If you have already cloned the ot-node repository: